On Tue, 3 Mar 2026 10:25:09 GMT, Liam Miller-Cushon <[email protected]> wrote:

>  This method may provide better space and time performance than {@link 
> #getBytes(Charset) getBytes(cs).length}.
> 
> what do you think?

I like this since it succinctly answers the user's question "Why/when should I 
consider using this method over getBytes(Charset).length?", without providing 
too many testable assertions or classifying choices as more or less good or 
bad. 

However, I think my usefullness here is perhaps asking questions rather than 
answering them :-) I'm sure other experienced reviewers can provide feedback on 
phrasing which feels in place with this API.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28454#discussion_r2877472056

Reply via email to