On Fri, 6 Mar 2026 00:35:54 GMT, Feilong Jiang <[email protected]> wrote:
>>> Great work! I think the javadoc needs some changes, but the rest looks spot >>> on. >> >> Thanks for the feedback. I've incorporated it, and also added the line we >> discussed offline. >> >>> > Hi @feilongjiang, @sid8606, @TheRealMDoerr, >>> > I'm pinging you since you were the original porters of RISC-V, s390x, and >>> > PPC. Please do ping other contributors to your ports if they are more >>> > appropriate to review this change. I've introduced the ability to set >>> > thread local data on your platforms. As stated above, I've smoke tested >>> > this change with a minimal test on these platforms using emulation. I >>> > haven't been able to run rigorous tests. Please take a look at the >>> > changes, run them on your favourite hardware, and let me know if there >>> > are any problems. Thanks in advance! >>> >>> Thanks for implementing it for all platforms! Looks correct and the >>> test/jdk/java/foreign tests have passed on PPC64 (linux and AIX). >>> @offamitkumar may also want to check s390. >> >> Thanks for trying it out! I appreciate it. > >> Hi @feilongjiang, @sid8606, @TheRealMDoerr, >> >> I'm pinging you since you were the original porters of RISC-V, s390x, and >> PPC. Please do ping other contributors to your ports if they are more >> appropriate to review this change. I've introduced the ability to set thread >> local data on your platforms. As stated above, I've smoke tested this change >> with a minimal test on these platforms using emulation. I haven't been able >> to run rigorous tests. Please take a look at the changes, run them on your >> favourite hardware, and let me know if there are any problems. Thanks in >> advance! > > @RealFYang May also want to take a look at the RISC-V port. > > > Hi @feilongjiang, @sid8606, @TheRealMDoerr, > > > I'm pinging you since you were the original porters of RISC-V, s390x, and > > > PPC. Please do ping other contributors to your ports if they are more > > > appropriate to review this change. I've introduced the ability to set > > > thread local data on your platforms. As stated above, I've smoke tested > > > this change with a minimal test on these platforms using emulation. I > > > haven't been able to run rigorous tests. Please take a look at the > > > changes, run them on your favourite hardware, and let me know if there > > > are any problems. Thanks in advance! > > > > > > @RealFYang May also want to take a look at the RISC-V port. > > @Arraying : The RISC-V part seems fine to me. My local `jdk_foreign` test > with fastdebug build on linux-riscv64 is good. BTW: You might want to enable > GHA on your fork. Thanks for taking a look! Good point, I've re-enabled GHA. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30059#issuecomment-4022208984
