On Wed, 11 Mar 2026 15:35:55 GMT, David Beaumont <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix bad import
>
> test/jaxp/javax/xml/jaxp/functional/org/w3c/dom/ptests/ElementTest.java line
> 236:
>
>> 234: public void testToString() throws Exception {
>> 235: final String xml =
>> 236: "<?xml version=\"1.0\" encoding=\"UTF-8\"
>> standalone=\"yes\"?>"
>
> I know it's not directly related, but the text here isn't actually split
> between lines (no trailing '\n') and text blocks are just easier to read.
Yes, and it's also because tests are generally not updated as new features
(e.g. text block) are introduced.
> test/jaxp/javax/xml/jaxp/functional/test/auctionportal/AuctionController.java
> line 364:
>
>> 362:
>> 363: /** Convert file contents to a given character set with BOM marker.
>> */
>> 364: public static InputStream utf16Stream(String file, ByteOrder
>> byteOrder)
>
> This is a simpler version of `bomStream` which cannot be used in JUnit test
> classes because it exists in JAXPTestUtilities, which cannot be used due to
> NestNG dependencies.
> This version is actually better because it lets us test with both possible
> byte orders, rather than only the native one.
>
> Alternatively (as in the case of the document compare util method) I could
> just remove this test from the PR until the utility class can be converted to
> JUnit.
Either way is fine with me. I'd say keep it in the PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30201#discussion_r2948606170
PR Review Comment: https://git.openjdk.org/jdk/pull/30201#discussion_r2948716378
