On Wed, 18 Mar 2026 14:42:16 GMT, David Beaumont <[email protected]> wrote:

>> src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java line 424:
>> 
>>> 422:                                 if (newModule.isEmpty()) {
>>> 423:                                     newModule = "<unknown>";
>>> 424:                                 }
>> 
>> In your testing, did you encounter cases that use this code path? (Just 
>> asking as I'm trying to think of resources aren't that in a module).
>
> You mean that would result in `<unknown>`?
> Not that I recall. This is just a neater way to get the module name, and 
> shouldn't change existing behaviour (since it's a well defined property of 
> the location).

No issue with the change, I'm just a bit wondering if it is even possible when 
jlink creates the image.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r2954018865

Reply via email to