On Fri, 13 Mar 2026 18:58:53 GMT, Frederic Thevenet <[email protected]> wrote:
>> When an `OutputAnalyzer` instance uses a `LazyOutputBuffer` impl to capture >> a process' standard output, it unconditionally writes progress logs to >> stdout. This can easily flood the output in tests that spawn a great number >> of processes, each with an OutputAnalyzer attached, as part of their >> operations. >> >> This change introduce an optional "quiet mode" which allows suppressing the >> diagnostic messages emitted by the analyzer. >> >> (Notes on implementation) >> * Introducing a "verbose mode" instead would likely have been more >> idiomatic, but would have implied a lot of existing tests opting into this >> new mode to retain their current printing behavior. >> * It is implemented as an extra parameter in new constructor overloads for >> `OutputAnalyzer`, which really is the only way since `LazyOutputBuffer` >> starts logging in its constructor. > > Frederic Thevenet has updated the pull request incrementally with one > additional commit since the last revision: > > Switch opt-in quiet mode for opt out verbose mode. Fix indent. Too late to fix the title, but you can still update the descriptions so they reflect what you actually did rather than saying you wanted to do it but didn't: > Introducing a "verbose mode" instead would likely have been more idiomatic, > but would have implied a lot of existing tests opting into this new mode to > retain their current printing behavior. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30238#issuecomment-4088242339
