On Thu, 19 Mar 2026 03:50:51 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Support "--win-with-ui" boolean option. If specified, jpackage will ensure
>> the output MSI or EXE installer will have User Interface (UI). The UI is
>> based on the standard "WixUI_Minimal" WiX dialog set with the WelcomeEulaDlg
>> dialog removed from the sequence.
>>
>> If any option that implicitly results in the installer with UI is specified
>> ("--win-dir-chooser", "--win-shortcut-prompt", "--license-file"), the
>> "--win-with-ui" option is ignored.
>>
>> Code changes:
>> - Refactor WixUiFragmentBuilder: move code constructing a model for WiX UI
>> source code generation to classes in a new "jdk.jpackage.internal.wixui"
>> package with unit test coverage.
>> - Refactor WixPipeline and WixVariables; add unit tests for WixVariables.
>> - Refactor WinInstallerUiTest to include coverage for the "--win-with-ui"
>> option.
>>
>> Additionally, fixed an issue in WinL10nTest.java that popped up when running
>> the tests locally with different versions of WiX toolkit.
>
> Alexey Semenyuk has updated the pull request incrementally with five
> additional commits since the last revision:
>
> - Ui -> UI in the new code
> - Fix a typo
> - msi-disable-actions.js: fix copyright header
> - Ui -> UI in the new code
> - Ui -> UI in the new code
Build change looks good.
-------------
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/30172#pullrequestreview-3976332224
