On Thu, 19 Mar 2026 18:41:42 GMT, Eirik Bjørsnøs <[email protected]> wrote:
> I could update the PR such that ZipCoder.getBytes throws > CharacterCodingException directly instead of rethrowing IAE. Would you like > me to go down that road? On the other hand, ZipCoder.toString also wraps CharacterCodingException in IllegalArgumentException. This is what causes ZipCoder.checkedHash to awkwardly declare `throws Exception` because the base class throws CharacterCodingException while the UTF8ZipCoder override of this method throws IllegalArgumentException via toString. Perhaps it would be better to leave this as-is in this PR and do a follow-up PR where we investigate if getBytes, toString and checkedHash can all be consolidated to just throw CharacterCodingException? WDYT? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30319#discussion_r2962130934
