On Thu, 12 Jun 2025 04:11:15 GMT, Thomas Stuefe <[email protected]> wrote:
> (for JDK 26) > > Note: This PR is a continuation of the old PR here: > https://github.com/openjdk/jdk/pull/25260; had to close the old one since I > had Skara problems after the JDK25 split-off. > > See the companion CSR (https://bugs.openjdk.org/browse/JDK-8357090) for the > ratio behind this removal. > > Patch > > - removes all code handling the VFORK mode. > - removes or clarifies comments explaining use of vfork by the JVM. > - we now print out an error message to stderr if the user still specifies > -Djdk.lang.Process.launchMechanism=vfork. Thanks @RogerRiggs . I restart now working on this, since the original showstopper for the accompanying CSR - the missing error reporting @jddarcy mentioned - are provided by the latest ProcessBuilder error reporting improvement. I will address your comments in the upcoming CSR/patch. Reviewer note: I originally intended to remove the remaining uses of _exit, since I don't like the not-flushing-of-IO-streams; _exit, to my knowledge, makes only sense in combination with vfork (since you don't want to run libc cleanup in the parent's memory space ) However, out of an abundance of caution, and to separate functional changes, I reverted that change and postponed it for a separate RFE. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25768#issuecomment-4096592640 PR Comment: https://git.openjdk.org/jdk/pull/25768#issuecomment-4098246181
