On Tue, 17 Mar 2026 17:44:55 GMT, David Beaumont <[email protected]> wrote:
>> David Beaumont has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit since the last revision:
>>
>> Remove redundant fail() calls and other feedback changes.
>>
>> * Remove redundant calls to fail()
>> * feedback
>
> test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogSupportBase.java line 102:
>
>> 100: protected void setUp() {
>> 101: String file1 =
>> getClass().getResource("CatalogSupport.xml").getFile();
>> 102: if (getSystemProperty("os.name").contains("Windows")) {
>
> This is a really complex and messy setup, which creates non-obvious code in
> test subclasses.
> I'd be happy to see if I can sort it out properly if you (my dear reviewer)
> are up for it.
Many of these tests are more than 10, 20 years old, there are definitely rooms
for improvement. It might be better to do so while fixing/enhancing the library.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30283#discussion_r3013193322
