On Tue, 31 Mar 2026 20:12:32 GMT, Paul Sandoz <[email protected]> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix small typo
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java line
> 940:
>
>> 938: * <ul>
>> 939: * <li> Conversion {@code int[4]:128 -> float[4]:128}:
>> 940: * invariant lane size (lanewise in-place, {@code ML=1}),
>
> Suggestion:
>
> * length-invariant (lanewise in-place, {@code ML=1}),
>
> ?
Here I want to say that the lanes keep the same number of bits -> lanewise
in-place. It is not about the number of lanes / length of the vector. What do
you think?
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java line
> 1039:
>
>> 1037: * <li> Bitwise Reinterpretation:
>> 1038: * {@code f(X)} is the bitwise image of {@code X} of the same vector
>> 1039: * bit size, only the lane boundaries are redrawn from {@code ETYPE}
>
> Suggestion:
>
> * {@code f(X)} is the bitwise image of {@code X} of the same shape,
> * only the lane boundaries are redrawn from {@code ETYPE}
>
> ?
> In that respect I think we may have some incorrect entries for rows of
> `reinterpretShape` and the logical result, which should be of the same shape.
I think this wording issue actually zipped through my head while trying to fall
asleep yesterday. Thanks for pointing it out.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30113#discussion_r3019797533
PR Review Comment: https://git.openjdk.org/jdk/pull/30113#discussion_r3019801833
