On Tue, 7 Apr 2026 16:25:25 GMT, Marcono1234 <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - review comments >> - fix typo in code comment >> - merge latest from master branch >> - 8378291: Test vector in >> test/jdk/java/util/jar/JarEntry/GetMethodsReturnClones.java is effectively >> unsigned > > test/jdk/java/util/jar/JarEntry/GetMethodsReturnClones.java line 115: > >> 113: certs = je.getCertificates(); // now get the certs again >> 114: assertNotNull(certs, "JarEntry.getCertificates() returned >> null for " + je.getName()); >> 115: // verify that the newly returned array doesn't have the >> overwrittent value > > Typo? > Suggestion: > > // verify that the newly returned array doesn't have the > overwritten value Good catch. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30602#discussion_r3050620578
