On Wed, 8 Apr 2026 08:50:40 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Please review this small cleanup which removes the fourth sentence of the >> class-level Javadocs of `java.lang.String`: >> >> _String buffers support mutable strings_ >> >> Mentioning "mutable strings" while just establishing that strings are >> immutable in Java is confusing. It is also unclear what "String buffers" >> should refer to. >> >> While it could be possible to improve the phrasing of this sentence, the end >> result would still be out of context here, so this PR suggests that we >> simply remove this sentence. >> >> This was initially discussed on core-libs: >> https://mail.openjdk.org/archives/list/[email protected]/thread/2WP6UB3LMJGTRPOJILFLTNEGVBDUCKAU/ >> >> Javadoc-only cleanup, `noreg-doc`. >> >> It is my understanding that this change is not normative and does not >> warrant a CSR. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Say that immutable before defining what that means Marked as reviewed by liach (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/30608#pullrequestreview-4075083007
