On Thu, 9 Apr 2026 07:49:48 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 1252:
>>
>>> 1250: return zc.getBytes(name);
>>> 1251: } catch (IllegalArgumentException e) {
>>> 1252: throw new InvalidPathException(name, "unmappable
>>> character in path name");
>>
>> InvalidPathException extends IllegalArgumentException so there should be no
>> compatibly impact to code that has been handling the IAE.
>
>> InvalidPathException extends IllegalArgumentException so there should be no
>> compatibly impact to code that has been handling the IAE.
>
> Thanks, I had not noticed. Just to be abundantly clear: Does this mean it's
> okay to withdraw the CSR and release note and proceed with just this PR?
It is of course possible that there is existing code that handles
InvalidPathException and the less specific IllegalArgumentException differently
but I think we are deep in the weeds at that point. So I agree that this one
doesn't strictly need a CSR or release note.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30584#discussion_r3056357548
