> Convert and tidy-up unit tests in test/jaxp/javax/xml/jaxp/unittest/stream.
> 
> It is recommended to set the diff settings in github to hide whitespace 
> (cog-wheel menu).
> 
> There are a lot of cases where manual catch blocks with explicit fail are 
> removed to just allow the test to fail idiomatically by throwing the 
> exception normally. This causes thousands of lines to be un-indented (with no 
> other change).
> 
> There are also several non-trivial changes in this PR related to badly 
> written tests where, for example, catching and ignoring exceptions allows the 
> test to pass under all situations.

David Beaumont has updated the pull request incrementally with one additional 
commit since the last revision:

  one more assertion simplification

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/30643/files
  - new: https://git.openjdk.org/jdk/pull/30643/files/5f6ef34c..9f54aaa6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=30643&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30643&range=00-01

  Stats: 10 lines in 1 file changed: 2 ins; 4 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/30643.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/30643/head:pull/30643

PR: https://git.openjdk.org/jdk/pull/30643

Reply via email to