On Thu, 9 Apr 2026 18:49:31 GMT, Sean Mullan <[email protected]> wrote:

>> Do you mean the file in the `include` directive? The problem with that is 
>> that file may not exist on the system you are running the `jlink` command 
>> from.
>> 
>> Or did you mean the file containing the properties you want to override? The 
>> latter would work, although it could be confusing to have more than one 
>> property with different values to someone reading the file manually. Perhaps 
>> it would be ok if I inserted a comment stating that properties below this 
>> line will override the above properties with the same name.
>
> The other thing is that if we did the latter, it may be debatable how 
> valuable this option is, when you could just do something like a `cat props 
> >> conf/security/java.security` :)

I meant the latter, the problem we observed with `cat props >> 
conf/security/java.security` is while linking a jmod-less image. The SHA-512 
checksum of the original `conf/security/java.security` file is stored in the 
jimage file (`lib/modules`). So if we modify `conf/security/java.security` and 
run `jlink` (in a jmod-less JDK), we get `Error: 
.../conf/security/java.security has been modified`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30635#discussion_r3060081121

Reply via email to