On Thu, 9 Apr 2026 21:39:20 GMT, Viktor Klang <[email protected]> wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> For rechecking v27 under head
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2107:
>
>> 2105: private int awaitWork(WorkQueue w, int phase) {
>> 2106: if (w != null) {
>> 2107: int activePhase = phase + IDLE, parking = 0;
>
> @DougLea the local `parking` doesn't look like it gets assigned to anything
> but its initial value, so it would seem like the following conditional would
> be dead code (likely bug):
>
>
> if (parking != 0) {
> w.parking = 0;
> LockSupport.setCurrentBlocker(null);
> }
Thanks! Mangled during a merge. Should say...
if (parking == 0) { // enable unpark
LockSupport.setCurrentBlocker(this);
! w.parking = parking = activePhase;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r3061073592
