On Fri, 10 Apr 2026 23:00:59 GMT, Xueming Shen <[email protected]> wrote:
>> Jatin Bhateja has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit since the last revision:
>>
>> Review comments resolutions
>
> test/jdk/jdk/incubator/vector/gen-tests.sh line 132:
>
>> 130: MaxValue=POSITIVE_INFINITY
>> 131: MinValue=NEGATIVE_INFINITY
>> 132: Type=Float16
>
> Type are not changed to "short", so unless this is just for explicitness, we
> might want to leave them out here. OK, I do noticed the Wideboxtype in flot
> & double.
type represent the primitive/carrier type while Type represent the box type.
> test/jdk/jdk/incubator/vector/gen-tests.sh line 141:
>
>> 139:
>> 140: abstractvectortype=${typeprefix}${Type}Vector
>> 141: abstractvectorteststype=${typeprefix}${Type}VectorTests
>
> I don’t see "abstractvectorteststype" being used anywhere. It might be worth
> considering removing it, along with
> "-Dabstractvectorteststype=$abstractvectorteststype" below, if it is indeed
> not being used here.
That's how its in the mainline code even without changes in the pull request.
We can address it separately.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r3071635578
PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r3071636135
