On Wed, 15 Apr 2026 14:54:25 GMT, Viktor Klang <[email protected]> wrote:
>> This is the API, implementation and test changes for [JEP >> 533](https://openjdk.org/jeps/533). >> >> The API changes are as per the summary in the JEP. Most of the changes in >> the PR are to the API docs as this update includes a pass over the docs to >> improve the readability and links. The Exception Handling section in the >> class description moves to after the Configuration section so the class >> description will look like it has more changes that it actually has. For the >> API docs then it might be easier to read the generated [API >> docs](https://cr.openjdk.org/~alanb/sc-jdk27/api/java.base/java/util/concurrent/StructuredTaskScope.html) >> rather the source. >> >> The implementation changes are most trivial. Much of the test changes are >> mechanical but there are a few new tests for new conditions and the new >> factory methods. >> >> API discussion should go to loom-dev, not the PR. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java > line 966: > >> 964: * >> 965: * <p> The predicate's {@code test(Object)} method must be >> thread safe as it may >> 966: * be invoked concurrently from several threads. If the {@code >> test(Object)} method > > @AlanBateman Not sure about the wording here, a Predicate doesn't "complete". > Perhaps say something like "of invoking the test(Object) method throws an > exception or error"?s I can't immediately see the issue here. The wording is "If the test(Object) method completes with an exception or error" (it used to say "If the test method completes with an exception or error"). We could change to "completely abnormally" or "fails with". In other areas of the API docs we speak of a subtask failing with an exception or error so maybe that is best. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30695#discussion_r3087458565
