On Thu, 16 Apr 2026 12:49:33 GMT, Marcono1234 <[email protected]> wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into pidzero
>> - remove files
>> - remove imports not needed
>> - fix
>
> test/jdk/java/lang/ProcessHandle/PidZero.java line 42:
>
>> 40: @Test
>> 41: public void test() {
>> 42: int num =
>> ProcessHandle.of(0).orElseThrow().descendants().toList().size();
>
> Should this have any assertion? E.g. `assertNotEquals(0, num)` /
> `assertTrue(num > 0)` (or at least a `assertDoesNotThrow` to clarify the
> intention)?
I can wrap the invocation in assertDoesNotThrow()
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30763#discussion_r3093471932
