On Thu, 9 Apr 2026 12:17:36 GMT, Severin Gehwolf <[email protected]> wrote:
>> Sean Mullan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make test be able to run with jmod-less image.
>
> test/jdk/tools/jlink/plugins/SecurityPropertiesPluginTest.java line 1:
>
>> 1: /*
>
> With this patch to the file the test becomes runnable with JEP 493 enabled as
> well (it's currently skipped).
>
>
> diff --git a/test/jdk/tools/jlink/plugins/SecurityPropertiesPluginTest.java
> b/test/jdk/tools/jlink/plugins/SecurityPropertiesPluginTest.java
> index 697816a2dc3..8d40dc60048 100644
> --- a/test/jdk/tools/jlink/plugins/SecurityPropertiesPluginTest.java
> +++ b/test/jdk/tools/jlink/plugins/SecurityPropertiesPluginTest.java
> @@ -27,6 +27,7 @@
> import java.util.Map;
> import java.util.Properties;
>
> +import jdk.tools.jlink.internal.LinkableRuntimeImage;
> import jtreg.SkippedException;
> import jdk.test.lib.Asserts;
> import tests.Helper;
> @@ -35,10 +36,11 @@
> * @bug 8377819
> * @summary Test the --security-properties plugin
> * @library ../../lib /test/lib
> - * @modules java.base/jdk.internal.jimage
> + * @modules jdk.jlink/jdk.tools.jlink.internal
> + * java.base/jdk.internal.jimage
> * jdk.jlink/jdk.tools.jimage
> * @build tests.*
> - * @run main SecurityPropertiesPluginTest
> + * @run main/othervm SecurityPropertiesPluginTest
> */
>
> public class SecurityPropertiesPluginTest {
> @@ -47,10 +49,11 @@ public class SecurityPropertiesPluginTest {
>
> private static String SECPROPS_PATH = "conf/security/java.security";
> private static String TEST_DIR = System.getProperty("test.dir", ".");
> + private static final boolean LINKABLE_RUNTIME =
> LinkableRuntimeImage.isLinkableRuntime();
>
> public static void main(String[] args) throws Throwable {
>
> - helper = Helper.newHelper();
> + helper = Helper.newHelper(LINKABLE_RUNTIME);
> if (helper == null) {
> throw new SkippedException("Test not run");
> }
Fixed in
https://github.com/openjdk/jdk/pull/30635/changes/a51cc5a132cf7febac8be08e5ebedc8490318429
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30635#discussion_r3093679859
