On Tue, 14 Apr 2026 15:34:33 GMT, Chen Liang <[email protected]> wrote:
>> Paul Hübner has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Remove extraneous export.
>> - Merge branch 'master' into JDK-8379630
>> - Different long sizes on different platforms.
>> - Use C standard library for the benchmark instead.
>> - Benchmark to measure call state capturing overhead.
>
> test/micro/org/openjdk/bench/java/lang/foreign/CaptureCallStateOverheadBench.java
> line 63:
>
>> 61: @State(Scope.Benchmark)
>> 62: @OutputTimeUnit(TimeUnit.NANOSECONDS)
>> 63: @Fork(value = 3, jvmArgs =
>> {"--add-exports=java.base/jdk.internal.foreign=ALL-UNNAMED",
>
> The add exports seems not necessary; you are not using anything from this
> package.
Good catch, removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30719#discussion_r3099893343
