On Fri, 17 Apr 2026 13:34:02 GMT, Severin Gehwolf <[email protected]> wrote:
>> src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java line 90: >> >>> 88: this.provider = provider; >>> 89: // TODO: Obtain and pass correct preview mode flag value here. >>> 90: this.image = SystemImage.open(PreviewMode.DISABLED); // open >>> image file >> >> I believe this breaks `ModuleReader.list()` >> [spec](https://docs.oracle.com/en/java/javase/26/docs/api/java.base/java/lang/module/ModuleReader.html#list()): >> >> Lists the contents of the module, returning a stream of elements that are >> the names of >> all resources in the module. Whether the stream of elements includes names >> corresponding >> to directories in the module is module reader specific. > > At least with the latest valhalla EA JDK, this doesn't list any value classes. jrtfs is not used by the system ModuleReader or any part of the runtime. jrtfs is for tooling, mostly javac, and doesn't strictly need to be in java.base. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r3101326805
