On Fri, 17 Apr 2026 13:47:27 GMT, Severin Gehwolf <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Rename ModuleReference to ModuleLink >> - tweak comments > > src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java > line 51: > >> 49: >> 50: // ImageReader to access resources in jimage. >> 51: private static final ImageReader READER = SystemImageReader.get(); > > This will use `ImageReader.open(..., PreviewMode.FOR_RUNTIME)` which is > likely not what it's intended for. Just a wrapper around resources in the > runtime image. e.g. `lib/modules`. It should use the `NONE` mode instead here > (give me all resources in the modules image). That's not correct. If you're running with enable preview, then `java.lang.Integer` *is* the preview mode version, and asking the get "the bytes for `java.lang.Integer`" in that runtime must give the bytes of the preview version. User or library code must not need to account for the preview mode itself. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r3111044732
