On Tue, 21 Apr 2026 08:42:04 GMT, David Beaumont <[email protected]> wrote:
>>> Also note, this is all tested for (either in tests in the PR, or tests in >>> lworld which will come in with later PRs). >> >> That fine. Is the lworld branch and this PR mostly in sync? I just want to >> makes sure that any testing I do with the lworld branch is applicable to the >> PR (it's easier to trying things out in the branch). > > Well I've obviously not pushed back changes made during this PR review into > lworld yet, but those are the only differences, and are not functional. > lworld has the exploded image logic in and all the plumbing to make the > compiler stuff work. I've done several passes over the changes in this PR. One thing that I'm now wondering the default (preview features disabled) could work like the raw API so that META-INF/preview are just resources in the module. It would be like disable MR processing in the comparison with MR JARs above. When preview features are enabled then META-INF/preview would overlay as it does now. Would this allow the side channel that is ResourceEntries go away? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r3116509181
