On Tue, 21 Apr 2026 10:33:43 GMT, Per Minborg <[email protected]> wrote:

> This PR proposes to increase the timeout of the test `StdLibTest` as it might 
> be slow on certain configurations (e.g., "zero"). The PR also proposes to 
> convert the test to use `junit`.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marked as reviewed by jvernee (Reviewer).

Alternatively we could bump the timeout factor of zero test runs. Right now it 
sits at `8`.

test/jdk/java/foreign/StdLibTest.java line 96:

> 94:         //day pf year in Java has 1-offset
> 95:         assertEquals(localTime.getDayOfYear() - 1, tm.yday());
> 96:         assertEquals( localTime.getDayOfMonth(), tm.mday());

Suggestion:

        assertEquals(localTime.getDayOfMonth(), tm.mday());

-------------

PR Review: https://git.openjdk.org/jdk/pull/30843#pullrequestreview-4147096993
PR Comment: https://git.openjdk.org/jdk/pull/30843#issuecomment-4287978813
PR Review Comment: https://git.openjdk.org/jdk/pull/30843#discussion_r3116909243

Reply via email to