On Wed, 22 Apr 2026 09:18:54 GMT, Per Minborg <[email protected]> wrote:
>> This PR proposes to improve the `TestBufferStackStress` and >> `TestBufferStackStress2` tests by removing an unnecessary `@build` tag and >> reducing the required work of `TestBufferStackStress`. >> >> The `TestBufferStackStress` is also proposed to be removed from the >> ProblemList as the underlying issue >> (https://bugs.openjdk.org/browse/JDK-8350455) has been fixed. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Address comments Hello Per, this looks good to me. Thank you for the update. My preference would have been to use the `jdk.test.lib.Platform` test utility because it already has the necessary infrastructure (including using `Locale.ROOT` when converting the os.name to lowercase), something like: import jdk.test.lib.Platform; ... /* * @test * ... * @build jdk.test.lib.Platform ... if (Platform.isOSX()) { // 8350455 was only fixed in macOS versions 26 or higher assumeFalse(Platform.getOsVersionMajor() < 26, "Unsupported OS version: " + osVersion); } but the current version you have is OK too. I would suggest running this in our CI once with a test-repeat of maybe 50 (so that it exercises the macos versions in use) before integrating. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30835#pullrequestreview-4154403383
