On Wed, 22 Apr 2026 10:49:21 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which removes support for the >> `-noclassgc`, `-noverify`, `-verifyremote` options from the `java` launcher >> and the `-Xverify:none` option from the VM? >> >> These options have been deprecated since some releases and have been >> printing a deprecation warning. There were a few more `java` launcher >> options which were deprecated for removal a while back through >> https://bugs.openjdk.org/browse/JDK-8340244. Those remaining ones will >> continue to stay deprecated but will be removed in some future version, >> given that they are relatively more commonly used. >> >> The CSR for this change is available for review >> https://bugs.openjdk.org/browse/JDK-8382727 and has additional details about >> this change. >> >> The `test/hotspot/jtreg/gc/shenandoah/compiler/CallMultipleCatchProjs.java` >> test had to be updated to remove its usage of `-Xverify:none`. That test was >> introduced in https://bugs.openjdk.org/browse/JDK-8231405, but I haven't >> been able to locate a RFR thread for that (I checked hotspot-gc-dev, >> shenandoah-dev mailing lists from September 2019), so it's not clear to me >> why the `-Xverify:none` was needed in that test. A brief look at that test >> suggests that this option may not be necessary, so I've removed it. Please >> take a look and let me know if that option was intentional (in which case we >> need to decide how we deal with that test with this option being removed). >> >> tier1, tier2, tier3 testing has completed without any related failures with >> this change. I plan to run higher tier tests in the coming days. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > remove mention of -Xverify:none from the java launcher help text src/java.base/share/classes/sun/launcher/resources/launcher.properties line 199: > 197: \ The actual size may be rounded up to a multiple > of the\n\ > 198: \ system page size as required by the operating > system.\n\ > 199: \ -Xverify sets the mode of the bytecode verifier\n\ Are the remaining modes explained anywhere? src/java.base/share/native/libjli/java.c line 1308: > 1306: } else if (JLI_StrCmp(arg, "-verify") == 0) { > 1307: JLI_ReportErrorMessage(ARG_DEPRECATED, "-verify"); > 1308: AddOption("-Xverify:all", NULL); Is this deprecated flag going to be handled separately? test/hotspot/jtreg/gc/shenandoah/compiler/CallMultipleCatchProjs.java line 30: > 28: * @requires vm.gc.Shenandoah > 29: * > 30: * @run main/othervm -XX:CompileOnly=CallMultipleCatchProjs::test -Xcomp > -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC CallMultipleCatchProjs Does the test not actually require that verification be disabled? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30877#discussion_r3123719365 PR Review Comment: https://git.openjdk.org/jdk/pull/30877#discussion_r3123727737 PR Review Comment: https://git.openjdk.org/jdk/pull/30877#discussion_r3123734291
