> In project valhalla development, we discovered that `Modifier.toString` 
> becomes more problematic than helpful: there's now a mix-and-match of 
> modifiers from access flags and other class file sources, for example, 
> classes now can have ACC_IDENTITY, which clashes with ACC_SYNCHRONIZED, and 
> the correct modifier to reflect, "value", must be deduced by the users 
> manually.
> 
> With fewer bits available for the access flags, it becomes more apparent that 
> future source modifiers will no longer be reflected by `Modifier.toString`, 
> and future access flags are more likely to be reflected incorrectly. Thus, we 
> should dissuade users from this API in the long run.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Chen Liang has updated the pull request incrementally with one additional 
commit since the last revision:

  Update copyright years

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/30093/files
  - new: https://git.openjdk.org/jdk/pull/30093/files/f67ea0ae..62f74322

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=30093&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30093&range=04-05

  Stats: 15 lines in 15 files changed: 0 ins; 0 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/30093.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/30093/head:pull/30093

PR: https://git.openjdk.org/jdk/pull/30093

Reply via email to