On Wed, 22 Apr 2026 19:33:29 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolutions
>
> src/hotspot/share/opto/vectornode.cpp line 1185:
>
>> 1183:
>> 1184: // Check whether we can push this vector op through a broadcast (all
>> inputs are Replicate).
>> 1185: bool VectorNode::can_push_through_broadcast(BasicType bt) {
>
> It makes sense to align the terminology used here. The operation is called
> broadcast while corresponding node is Replicate. (I know that
> `vectorIntrinsics.cpp` use them interchangeably, but let's not worsen the
> situation. `vectorIntrinsics.cpp` can be cleaned up later.)
Hi @iwanowww , addressed.
Kindly share the results of your test runs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25617#discussion_r3135648900
