Hi Jai, I will look at this today, it has been on my list… Apologies
On Apr 24, 2026, at 7:24 AM, Jaikiran Pai <[email protected]> wrote: On Wed, 22 Apr 2026 09:41:42 GMT, Jaikiran Pai <[email protected]> wrote: Can I please get a review of this test-only change which updates the `test/jdk/tools/jar/JarExtractTest.java` test to use the jtreg scratch directory for its temporary files? In addition to that change, the `testExtractNoDestDirWithPFlag` is a bit different and that one intentionally expects to write out to a directory that starts with a leading slash in its path. We use `/tmp` directory in that test intentionally. In this PR, that test method now cleans up the `/tmp/` directory after the test is done. I've looked through the discussions in the PR for JDK-8173970, where this test was introduced and I've verified that this change doesn't impact any original expectations of this test. I've also verified that the test continues to pass with this change on all platforms in our CI. --------- - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision: - make static field final in test - newline at end of file Thank you Matthias. Alan, Lance, do you think the changes are fine and the new code comment looks OK? ------------- PR Comment: https://git.openjdk.org/jdk/pull/30847#issuecomment-4312762098 [oracle_sig_logo.gif] Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected]
