On Fri, 24 Apr 2026 16:21:54 GMT, Markus Grönlund <[email protected]> wrote:
>> Greetings, >> >> please see [JDK-8382332](https://bugs.openjdk.org/browse/JDK-8382332) for >> detailed information about this issue. >> >> Testing: jdk_jfr, tier1-6, SpecJbb2015 >> >> Thanks >> Markus >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Markus Grönlund has updated the pull request incrementally with one > additional commit since the last revision: > > macros src/java.base/share/classes/jdk/internal/event/FinalFieldMutationEvent.java line 66: > 64: int newRootFieldSlotEpoch = > 65: currentEpoch << JfrEpochGeneration.EPOCH_SHIFT_INT | > (slot & JfrEpochGeneration.VALUE_MASK_INT); > 66: return JfrEpochGeneration.compareAndExchange(root, > SLOT_OFFSET, slot, newRootFieldSlotEpoch); Drive-by-comment: Can you make `slot` non-final? I'm afraid there is a chance the JIT will not produce correct code for accesses into this field if it lies about its finality. See [JDK-8379875](https://bugs.openjdk.org/browse/JDK-8379875). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30922#discussion_r3142443192
