On Tue, 28 Apr 2026 06:12:35 GMT, Emanuel Peter <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remving duplicate IRNode definitions after latest mainline merge
>
> src/hotspot/share/opto/vectornode.cpp line 1127:
>
>> 1125: }
>> 1126:
>> 1127: static bool is_commutative_vector_operation(int opcode) {
>
> This is assuming that the operation is not masked, right? You may want to put
> this caveat as a code comment.
Suggestion:
// Check if the vector operation is commutative (assuming that it is not
predicated/masked)
static bool is_commutative_vector_operation(int opcode) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25617#discussion_r3151938935
