On Tue, 28 Apr 2026 16:18:53 GMT, Jorn Vernee <[email protected]> wrote:
>> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 60 additional >> commits since the last revision: >> >> - Merge branch 'master' into >> implement-lazy-constants-third-prewiew-exceptions >> - Merge branch 'openjdk:master' into master >> - Improve TestSegmentOffset and convert to junit >> - Address comments in PR >> - Change the way throwing toString is handled >> - Improve LazyMap tests >> - Harden tests >> - Update code style in if branch >> - Reorder modifiers >> - Merge branch 'master' into >> implement-lazy-constants-third-prewiew-exceptions >> - ... and 50 more: https://git.openjdk.org/jdk/compare/da66497e...f67028cd > > test/jdk/java/lang/LazyConstant/LazyMapTest.java line 309: > >> 307: ref.set(lazy); >> 308: var x = assertThrows(NoSuchElementException.class, () -> >> lazy.get(key)); >> 309: assertTrue(cnt.get() > 0); > > Should be exactly 1 right? Because we recurse and fail on the second run, the count would be 2. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30194#discussion_r3161745138
