On Wed, 29 Apr 2026 20:58:08 GMT, Vladimir Ivanov <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Workaround issues
>
> src/hotspot/share/opto/bytecodeInfo.cpp line 368:
>
>> 366: if (DelayAfterInliningCutoff) {
>> 367: return false;
>> 368: } else if (callee->force_inline() ||
>> callee->is_compiled_lambda_form()) {
>
> Just noticed: it is `caller_method->is_compiled_lambda_form()` in the
> original code.
My mistake, it is fixed now.
> src/hotspot/share/opto/bytecodeInfo.cpp line 416:
>
>> 414: // parsing in the caller, and node liveness is more easily
>> determined.
>> 415: if (C->over_inlining_cutoff()) {
>> 416: if (should_give_up_after_inlining_cutoff(callee_method)) {
>
> There's a family of `should_delay_*` methods on `Compile`. Placing the helper
> method there looks more appropriate. And speaking of naming, IMO
> `should_delay_*` reads better than `should_give_up_*`.
>
> Otherwise, the patch looks good.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30874#discussion_r3164195361
PR Review Comment: https://git.openjdk.org/jdk/pull/30874#discussion_r3164193715
