On Mon, 27 Apr 2026 14:42:57 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please find here a small change that converts `java.logging` TestNG tests to >> use JUnit. Most java.logging tests are plain jtreg tests, so this is a small >> set. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'master' into junit-logging-8382264 > - Review feedback > - Review feedback > - 8382264: Refactor java.logging TestNG tests to use JUnit This looks OK to me. test/jdk/java/util/logging/modules/GetResourceBundleTest.java line 50: > 48: * @summary Tests Logger.getLogger + logger.getResourceBundle in an > named/unnamed module, > 49: * resources are in named and unnamed modules respectively. > 50: * Positive tests to ensure that a Logger can retrieve > ResourceBundle in its current module. Nit - Pre-existing, it would be preferable to have the `@summary` before the `@run` tag https://openjdk.org/jtreg/tag-spec.html#ORDER. But it's OK if you don't want to address that in this PR ------------- PR Review: https://git.openjdk.org/jdk/pull/30769#pullrequestreview-4205204331 PR Review Comment: https://git.openjdk.org/jdk/pull/30769#discussion_r3167998679
