On Thu, 30 Apr 2026 16:30:56 GMT, Justin Lu <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
> line 176:
>
>> 174: @Override
>> 175: public String getDateTimeFormatterPattern(String
>> requestedTemplate, String calType, Locale locale) {
>> 176: throw new DateTimeException("""
>
> If there is time, I think adding a HOST specific test/run that confirms this
> behavior would help with coverage. As far as I can tell there aren't any
> existing tests before this PR that accomplished that.
That would be nice, but I think it is beyond what this PR covers.
> test/jdk/java/util/PluggableLocale/DateTimeFormatterPatternProviderTest.java
> line 155:
>
>> 153: public void testGetLocalizedDateTimePattern_4args(FormatStyle
>> dateStyle, FormatStyle timeStyle, String calType, Locale loc) {
>> 154: assertEquals("'date style: " + dateStyle + ", timeStyle: " +
>> timeStyle + ", calType: " + calType + ", loc: " + loc + "'",
>> 155: new
>> DateTimeFormatterBuilder().getLocalizedDateTimePattern(dateStyle, timeStyle,
>> Chronology.of(calType), loc));
>
> nit: feels odd to create instances when we're calling static methods.
Right. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30979#discussion_r3169670433
PR Review Comment: https://git.openjdk.org/jdk/pull/30979#discussion_r3169676324
