On Thu, 7 May 2026 09:58:15 GMT, Galder Zamarreño <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolution
>
> src/hotspot/cpu/x86/x86.ad line 14734:
>
>> 14732: format %{ "convert_hf2l $dst, $src !\t using $xtmp as TEMP" %}
>> 14733: ins_encode %{
>> 14734: __ convertHF2I(T_LONG, $dst$$Register, $src$$Register,
>> $xtmp$$XMMRegister);
>
> Minor comment: isn't it a bit confusing to call `convertHF2I` with a
> `T_LONG`? Maybe `convertHF2I` could be renamed to `convertHF2X` to not commit
> to the type?
Addressed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30928#discussion_r3223635348
