> On the review for [JDK-8380955](https://bugs.openjdk.org/browse/JDK-8380955) > (#30443), `Linker` and `FunctionDescriptor` do not need to be value based > class because they would not be treated as "value". > `Linker` is defined as providing a way to look up the canonical layouts > associated with the data types used by the ABI. `FunctionDescriptor` > represents the signature of a foreign function. They are not "value". > > Actually they and their child (final) classes do not have `@ValueBased`, thus > `javac` and `-XX:DiagnoseSyncOnValueBasedClasses` cannot identify if they are > used in anti-pattern of value based class. Thus this change does not change > behavior, just documentation updates. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Yasumasa Suenaga has updated the pull request incrementally with two additional commits since the last revision: - Add @ValueBased to FunctionDescriptorImpl - Revert the change in FunctionDescriptor ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30481/files - new: https://git.openjdk.org/jdk/pull/30481/files/8b55998a..f79b07d0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30481&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30481&range=00-01 Stats: 7 lines in 2 files changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/30481.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30481/head:pull/30481 PR: https://git.openjdk.org/jdk/pull/30481
