On Thu, 26 Mar 2026 02:25:17 GMT, Brian Burkhalter <[email protected]> wrote:

>> On Windows, relax the success criterion of `ListRoots` to the values 
>> returned by `File.listRoots` intersecting the values returned by 
>> `FileSystem.getRootDirectories` instead of being equal.
>
> Brian Burkhalter has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8379535: Address recent comments

> The latest version of this PR, commit 
> [906b62a](https://github.com/openjdk/jdk/commit/906b62a2ed44284c4fea434e8b83c707cf4ed80c),
>  passed on all the usual platforms in the CI in March. I think it is better 
> than what is currently in the mainline even if it could use further 
> improvement subsequently.

I think so, I'll also do some testing with it. That said, I think Arno has 
found one of the smoking guns, meaning there is a good change the ListRoots and 
GetCanonicalPath tests run concurrently. It's another example of where we need 
a way for jtreg to not run specific tests concurrently with any other tests 
(`exclusive.dirs` is not flexible enough).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30301#issuecomment-4552206300

Reply via email to