On Wed, 27 May 2026 14:08:28 GMT, Alan Bateman <[email protected]> wrote:
>>> @wkia Are you planning to continue this PR? >> >> @AlanBateman Yes, I'd like to continue. And sorry, maybe I misunderstood >> what you wrote before. Should I do something additionally to test the >> changes? > >> Should I do something additionally to test the changes? > > I think so as a failure right now might cause interference for other tests > that run subsequently on the system. > @AlanBateman I've changed the order of directories creation and drive mapping > to correctly remove the drive on failure. > > I believe there is no need to remove neither tmpDir nor tmpDirLink, as they > are located in the test working directory, so they don't interfere other > tests. Thanks, doing the "net use" as the last step in that block is good. It was an exception after setting up the mapping that I was concerned about. So I think the change is good. Just doing some more testing before marking it as reviewed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31192#issuecomment-4576087673
