On Thu, 4 Jun 2026 08:17:18 GMT, Per Minborg <[email protected]> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8374154
>> - preserve old getTextSid; better error handling
>> - 8374154: Rewrite JAAS NTLoginModule with FFM
>> - revert three accidentally modified files
>> - Simpler GLE-methods that display error texts inside it; LocalFree
>> - the fix
>
> src/jdk.security.auth/share/classes/com/sun/security/auth/module/NTSystem.java
> line 108:
>
>> 106: .downcallHandle(OpenThreadToken$address(),
>> OpenThreadToken$descriptor(), CCS_GLE);
>> 107:
>> 108: private int OpenThreadTokenGLE(MemorySegment ThreadHandle, int
>> DesiredAccess, int OpenAsSelf, MemorySegment TokenHandle) {
>
> These methods seem to share the same fundamental logic. Is it possible to
> consolidate?
The methods are generated by `doc-files/AddGLE.java`, therefore you see the
duplicated structure. I'd like to keep them as-is until someday `jextract`
supports the style directly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30629#discussion_r3357315990
