On Fri, 5 Jun 2026 08:33:49 GMT, Erik Gahlin <[email protected]> wrote:
>> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Switch order of fields. > > src/java.base/share/classes/sun/security/ssl/Finished.java line 1191: > >> 1189: } >> 1190: long peerCertificateId = Integer.toUnsignedLong(hash); >> 1191: String namedGroup = "N/A"; > > Not sure if it matters, but more expensive operations are typically moved > inside shouldCommit() so they are only executed if the event is about to be > committed. Yes, good advice, however there is already a check for that on line 1179. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31371#discussion_r3364030759
