On Tue, 2 Jun 2026 12:28:09 GMT, Quan Anh Mai <[email protected]> wrote:

>> Hi,
>> 
>> I was reminded of this forgotten PR when reviewing a counted loop 
>> transformation PR. The important point is that it is easier and more 
>> efficient to compute the trip count of a counted loop using unsigned 
>> division. Currently, for int counted loops, trip count is computed by 
>> extending the loop parameters to long and doing a signed long division. This 
>> cannot be applied to long counted loop. As a result, as a precondition for 
>> long counted loop predication, we need to be able to efficiently transform 
>> an unsigned division by constant.
>> 
>> For more information, please refer to #9947 .
>> 
>> Testing:
>> 
>> - [x] tier1-4,hs-comp-stress
>> 
>> Please take a look and leave your review, thanks a lot.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Quan Anh Mai has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains 101 commits:
> 
>  - Merge branch 'master' into unsignedDiv
>  - Fix comments, remove dead code
>  - Merge branch 'master' into unsignedDiv
>  - Various fixes
>  - Fix IntegerDivValueTests
>  - Fix merge conflicts
>  - Merge branch 'master' into unsignedDiv
>  - Merge branch 'master' into unsignedDiv
>  - fix tests
>  - Merge branch 'master' into unsignedDiv
>  - ... and 91 more: https://git.openjdk.org/jdk/compare/f823e3f7...13e52169

Can I have a second review for this PR, please?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31033#issuecomment-4671891486

Reply via email to