On Tue, 16 Jun 2026 05:03:36 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > src/java.base/share/classes/java/lang/classfile/package-info.java line 516: > >> 514: * | InnerClassesAttribute?(List<InnerClassInfo> classes) >> 515: * | PermittedSubclassesAttribute?(List<ClassEntry> >> permittedSubclasses) >> 516: * | LoadableDescriptorsAttribute?(List<Utf8Entry> >> loadableDescriptors) > > Should there be any indication here in the package-info text that > `LoadableDescriptorsAttribute` is a preview only construct? I personally would prefer throwing away this whole block - these should have been self-evident from the API specs, without manual specification. But that's out of scope for JEP 401. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3421517778
