On Thu, 18 Jun 2026 12:01:59 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which moves the `jdk.naming.rmi` >> module to be loaded by the platform loader, instead of the boot loader? >> >> This module doesn't require anything that would necessitate it to be part of >> the boot loader modules and such can be moved to the modules that belong to >> the platform loader. >> >> This module provides the `javax.naming.spi.InitialContextFactory` service. >> Before this change, the service would be located and loaded using the boot >> classloader and now will instead be loaded using the platform classloader. I >> believe this change to the service loading is an observable change and would >> thus require a CSR. I'll create one shortly. >> >> A new jtreg test has been introduced to verify that the >> `InitialContextFactory` service provided by the `jdk.naming.rmi` module >> doesn't get loaded by the boot loader. The test passes with this change and >> fails (as expected) without the source change. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - merge latest from master branch > - merge latest from master branch > - 8154193: Deprivilege jdk.naming.rmi module Thank you all for the inputs and the reviews. I'll go ahead and integrate this now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31480#issuecomment-4742505255
