On Thu, 18 Jun 2026 20:54:29 GMT, Dean Long <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2822 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317278 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8386690: [lworld] cherry-pick JDK-8386124 Test >> serviceability/sa/TestG1HeapRegion.java failed: Address of G1HeapRegion does >> not match >> >> Reviewed-by: liach >> - 8385743: [lworld] investigate and address build related comments in the >> Valhalla PR >> >> Reviewed-by: liach, erikj >> - 8376346: [lworld] Basic Shenandoah support >> >> Reviewed-by: qamai >> - 8386598: [lworld] C1 acmp profiling fix and minor cleanup >> >> Reviewed-by: mchevalier >> - 8386618: [lworld] Remove unused entry_guard_Relocation >> >> Reviewed-by: chagedorn, jsjolen, jsikstro >> - Merge >> >> Merge jdk-28+2 >> - 8386623: [lworld] Cleanup module support for system modules in JDK >> exploded build with preview resources >> >> Reviewed-by: liach >> - 8386316: [lworld] Replace Valhalla since version with 28 >> >> Reviewed-by: darcy >> - ... and 2812 more: https://git.openjdk.org/jdk/compare/6def7d55...c2d3cf01 > > src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp line 286: > >> 284: LIR_Opr lock = new_register(T_INT); >> 285: // Need a scratch register for inline types on x86 >> 286: LIR_Opr scratch = new_register(T_ADDRESS); > > Suggestion: > > > A temp register is always needed now, so let's keep the mainline version. Addressed with [JDK-8387274](https://bugs.openjdk.org/browse/JDK-8387274). > src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp line 302: > >> 300: CodeEmitInfo* info = state_for(x, x->state(), true); >> 301: monitor_enter(obj.result(), lock, syncTempOpr(), scratch, >> 302: x->monitor_no(), info_for_exception, info, >> throw_ie_stub); > > Suggestion: > > LIR_Opr tmp = new_register(T_ADDRESS); > monitor_enter(obj.result(), lock, syncTempOpr(), tmp, > x->monitor_no(), info_for_exception, info); Addressed with [JDK-8387274](https://bugs.openjdk.org/browse/JDK-8387274). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3472433724 PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3472433806
