On Fri, 26 Jun 2026 13:59:28 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2859 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317278 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - Merge >> >> Merge jdk-28+4 >> - 8386963: [lworld] Improve the exception message from Object >> synchronization methods on value objects >> >> Reviewed-by: dholmes, alanb >> - 8387300: [lworld] Minor review comments in javac >> >> Reviewed-by: vromero >> - 8387192: [lworld] Review comment drop for core libs >> >> Reviewed-by: jvernee, vromero >> - 8386999: [lworld] C2: assert(is_dead_loop_safe()) failed: shouldn't be >> cleared yet >> >> Reviewed-by: qamai, vlivanov >> - 8386787: [lworld] >> compiler/valhalla/inlinetypes/TestValueConstruction.java#StressIncrementalInliningDontInlineMyAbstractInit >> timed out >> >> Reviewed-by: phubner, chagedorn >> - 8386995: [lworld] Duplicate value classes are a preview feature warning >> >> Reviewed-by: alanb, vromero >> - 8383389: [lworld] Augment AOTMapLogger::print_oop_details to support flat >> arrays with oops >> >> Reviewed-by: iklam, fparain >> - ... and 2849 more: https://git.openjdk.org/jdk/compare/193de1b1...cffcfb57 > > src/java.base/share/classes/jdk/internal/vm/annotation/NullRestricted.java > line 48: > >> 46: @Target(ElementType.FIELD) >> 47: @Retention(RetentionPolicy.RUNTIME) >> 48: public @interface NullRestricted { > > As far as I can see, neither JEP 401 nor the "Strict Field Initialization in > the JVM" JEP proposes or specifies null-restricted semantics for fields. I > looked around for the usages of this annotation and can't find it being > annotated on anything in the production source. The only references to it (as > far as I can see) are in test cases and class file parsing (which is > production source). > > Is this annotation, the class file parsing of this annotation and the tests > related to null-restricted semantics unavoidable for the implementation of > JEP 401 and "Strict Field Initialization in the JVM" implementation? Or would > it be possible to leave these out? These changes are intentional and are needed to continue to support our test cases for null-restriction semantics. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3482625858
