On Thu, 25 Jun 2026 09:55:31 GMT, Viktor Klang <[email protected]> wrote:
>> Mat Carter has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use getVolatile instead of getAcquire
>
> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
> line 392:
>
>> 390:
>> 391: final Thread getAcqWaiter() {
>> 392: return (Thread)WAITER.getAcquire(this);
>
> @DougLea Are you OK with this change, or should we make the access even
> stronger?
This isn't sufficient, it needs a Java volatile load as it needs to be ordered
with a different variable. This just happens to work with our current choice of
loadAcquire instruction on ARM64 (as @merykitty has pointed out).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31465#discussion_r3474038784
