On Fri, 10 Jul 2026 18:02:18 GMT, Naoto Sato <[email protected]> wrote:
>> Sholto has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8272194: introduce faster code path for LocalDate/LocalDateTime conversion > > src/java.sql/share/classes/java/sql/Date.java line 328: > >> 326: year = calendar.get(Calendar.YEAR); >> 327: } >> 328: return LocalDate.of(year, calendar.get(Calendar.MONTH) + 1, >> calendar.get(Calendar.DAY_OF_MONTH)); > > The values of these fields should continue to be obtained by calling > `getYear()`, `getMonth()`, and `getDate()`, rather than from the calendar > instance. Otherwise, if a subclass overrides any of these methods, the > override would be ignored. Updated as suggested. I have done this on `Timestamp` as well. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3569746149
