On Wed, 15 Jul 2026 16:32:18 GMT, Naoto Sato <[email protected]> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add mention of `GregorianCalendar` in the example
>
> src/java.base/share/classes/java/text/SimpleDateFormat.java line 925:
> 
>> 923:      * Sets the start date of the 100-year period used to interpret 
>> 2-digit years.
>> 924:      * <p>
>> 925:      * For example, if the start date is set to January 1, 1950, 
>> 2-digit years
> 
> I overlooked this during our internal discussion that this example is 
> specific to `GregorianCalendar`, so something like:
> 
> * For example, for a {@code SimpleDateFormat} with a {@code 
> GregorianCalendar},
> * if the start date is set to January 1, 1950, ...
> 
> would be more appropriate.

Changed to `For example, given a ..., if the start date is ... ` in 
81c8c19f4c5. (Preferred `given a` to avoid repeating `for`.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31909#discussion_r3593788507

Reply via email to